modify resetall to work with patch object #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadycuz
commented
May 6, 2021
tests/test_pytest_mock.py
Outdated
Comment on lines
313
to
315
| # Testing spy can still be reset. | ||
| mocker.resetall() | ||
|
|
There was a problem hiding this comment.
Found a working test case. If you add this line to the previous version 3.6.0 then it triggers the error.
|
I now believe the failure happens when |
Yeah autospec is a bit convoluted... IIRC we can't use autospec with classmethod (or staticmethod) for example. |
|
Thanks a lot @shadycuz, appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237
It seems
spyandpatch.objecthave areset_mockthat doesn't take thereturn_valueandside_effectkeyword args.I originally tried to fix this in
_start_patchpytest-mock/src/pytest_mock/plugin.py
Lines 171 to 178 in c387818
but changing
self._mocks.append(mocked)to only append actuallyMockobjects breaks my repo worse because then I lose the ability to callresetallon patched objects.This seemed like the best approach to take.
I also tried to get this to fail in a test case but could not get the error to trigger. I suspect the issue might be with the version of
mockorunittest.mockthat our projects are using. I should be on the lastest of everything, but I'm still facing the error which is strange 🤔Here is my repo DontShaveTheYak/cloud-radar#32 if you want to try and debug it.